Codecov Report

Merging #4071 (aed32c2) into main (67b23aa) will not change coverage.
The diff coverage is n/a.

❗ Current head aed32c2 differs from pull request most recent head 2c1aed2. Consider uploading reports for the commit 2c1aed2 to get more accurate results

@@           Coverage Diff           @@
##             main    #4071   +/-   ##
=======================================
  Coverage   64.12%   64.12%           
=======================================
  Files          36       36           
  Lines        1873     1873           
  Branches      379      379           
=======================================
  Hits         1201     1201           
  Misses        571      571           
  Partials      101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b23aa...2c1aed2. Read the comment docs.

✨ Coder.com for PR #4071 deployed! It will be updated on every commit.

• Host: https://codercom-24nhqq4a9-codercom.vercel.app/docs/code-server
• Last deploy status: success
• Commit: 2c1aed2
• Workflow status: https://github.com/cdr/code-server/actions/runs/1211111027

Checked the preview. Looks good! @BrunoQuaresma any idea why the docs are making this shield round?

When I look at it in the browser, it's square like the others. See here

@jsjoeio I will check it. Probably a random CSS class. Also, when adding badges, it is recommended to make it a link, even if it is only an image. When it is an image, you can make it a link pointing to the image itself. It is how GH does to make their badges inline. You can inspect how our README.md looks like on GH inspecting the badges.

@jsjoeio also, looks like we are not closing a code block here:

It looks like the bash block is inside of another block.

When it is an image, you can make it a link pointing to the image itself. It is how GH does to make their badges inline. You can inspect how our README.md looks like on GH inspecting the badges.

Ah okay, I'll match that.

also, looks like we are not closing a code block here:

Nice catch! I'll fix that too

When it is an image, you can make it a link pointing to the image itself. It is how GH does to make their badges inline. You can inspect how our README.md looks like on GH inspecting the badges.

Ah okay, I'll match that.

I just checked and these are already links 🤔 Not sure what else we can do then.

Ready for another review! @BrunoQuaresma

@jsjoeio I sent a PR just fixing the link on the terminal badge.

I'll merge after I get this merged in: #4085

@jsjoeio I need to tell, the ngrok URL changes every time, as well as the port. One time you run ngrok, you get 0.tcp.ngrok.io and port 19028, but the next time you run it, you will get 2.tcp.ngrok.io and 10320, and it goes on. So, add in this case, to the ngrok guide where the port is mentioned and add a note that the port and the URL always changes so you have to use the URL and the port given on the terminal.

Ahh good call @im-coder-lg - thanks for mentioning that!

👍